build: fix ci cacheing to use recently built caches #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
commented
Jan 17, 2022
alexeagle
reviewed
Jan 18, 2022
f0rmiga
reviewed
Jan 18, 2022
alexeagle
reviewed
Jan 19, 2022
|
Updated. @alexeagle I wrote a more verbose (but hopefully clearer) explanation. @f0rmiga I removed the cache location flags outside of the bazelrc file as it doesn't support environment variables. |
alexeagle
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexeagle
Github actions caches don't update already existing caches, so the cache that gets loaded could be old. This sets a new cache using a cache key derived from a hash of files. The use of
restore-keys: bazel-cache-will find the most recent cache stored scoped to this branch or a parent branch.